Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default parser was removed from prettier #15

Merged
merged 1 commit into from
May 28, 2018

Conversation

pwang2
Copy link
Contributor

@pwang2 pwang2 commented May 27, 2018

@lovemyliwu
Copy link

why still not merged?

@yyx990803 yyx990803 merged commit 598224d into vuejs:master May 28, 2018
@pwang2 pwang2 deleted the fix-prettier-default-parser-removal branch May 28, 2018 03:53
@yyx990803
Copy link
Member

@lovemyliwu it's Sunday in US, and open source developers also have a life.

CasparChou added a commit to CasparChou/vue-loader that referenced this pull request May 28, 2018
same as [fix: default parser was removed from prettier](vuejs/component-compiler-utils#15)
@rof20004
Copy link

Well, I will take some coffee and wait!

:)

@lafeer
Copy link

lafeer commented May 28, 2018

so what needs to be done to fix this?

@iidear
Copy link

iidear commented May 28, 2018

@lafeer npm i prettier@~1.12.0

@lafeer
Copy link

lafeer commented May 28, 2018

I still get this :/

ERROR in ./node_modules/vue-loader/lib/template-compiler?{"id":"data-v-4099cde5","hasScoped":false,"optionsId":"0","buble":{"transforms":{}}}!./node_modules/vue-loader/lib/selector.js?type=template&index=0!./web/src/js/components/Tabs.vue
Module build failed: Error: No parser and no file path given, couldn't infer a parser.
at normalize (/builds/frontend/xy-cms/node_modules/prettier/index.js:7051:13)
at formatWithCursor (/builds/frontend/xy-cms/node_modules/prettier/index.js:10370:12)
at /builds/frontend/xy-cms/node_modules/prettier/index.js:31115:15
at Object.format (/builds/frontend/xy-cms/node_modules/prettier/index.js:31134:12)
at Object.module.exports (/builds/frontend/xy-cms/node_modules/vue-loader/lib/template-compiler/index.js:73:23)
@ ./web/src/js/components/Tabs.vue 6:0-333
@ ./web/src/main.js

edmorley added a commit to neutrinojs/neutrino that referenced this pull request May 28, 2018
To fix the Vue preset failures on master due to the Prettier
breaking API change in 1.13.0:
vuejs/component-compiler-utils#15
 vuejs/vue-loader#1323

The lockfile has been updated manually since Renovate's weekly PR
isn't currently working:
renovatebot/renovate#2033

Fixes #913.
edmorley added a commit to neutrinojs/neutrino that referenced this pull request May 28, 2018
To fix the Vue preset failures on master due to the Prettier
breaking API change in 1.13.0:
vuejs/component-compiler-utils#15
vuejs/vue-loader#1323

Closes #913.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.